From 47312797e2e7f523fbb954244e85d19b67cf4b21 Mon Sep 17 00:00:00 2001 From: Wolfvak Date: Sun, 29 Sep 2019 15:57:03 -0300 Subject: [PATCH] Partially fix #537 if size was zero, the inputstr array could contain stack garbage --- arm9/source/common/ui.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arm9/source/common/ui.c b/arm9/source/common/ui.c index a439085..078f821 100644 --- a/arm9/source/common/ui.c +++ b/arm9/source/common/ui.c @@ -920,7 +920,9 @@ bool ShowDataPrompt(u8* data, u32* size, const char *format, ...) { bool ret = false; va_list va; - if (*size > 64) *size = 64; + if (*size == 0) *inputstr = 0; + else if (*size > 64) *size = 64; + for (u32 i = 0; i < *size; i++) snprintf(inputstr + (2*i), 128 + 1 - (2*i), "%02X", (unsigned int) data[i]);